Improve inference for truethy comparisons#5521
Open
staabm wants to merge 3 commits intophpstan:2.1.xfrom
Open
Conversation
| )->setRootExpr($rootExpr)); | ||
| } | ||
|
|
||
| if ( |
Contributor
There was a problem hiding this comment.
-
Should the same be done with $context->false() && $constantType->toBoolean()->isFalse()->yes() ?
-
Why only
$exprNode instanceof FuncCall || $exprNode instanceof Expr\MethodCall || $exprNode instanceof Expr\StaticCall? Shouldn't this be for every $exprNode ? Or at least NullsafeMethodCall (and so) too ?
I wonder if changing the two previous $constantType into $constantType->toBoolean doesnt give the same result...
staabm
commented
May 10, 2026
Comment on lines
+106
to
+111
| if (strpos($s, '0') == 0) { // 0|false | ||
| assertType('string', $s); | ||
| } else { | ||
| assertType('string', $s); | ||
| } | ||
| assertType('string', $s); |
Contributor
Author
There was a problem hiding this comment.
we need a separate test with a function not specified further in StrContainingTypeSpecifyingExtension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply truthy narrowing for function calls compared to truthy constants (
TypeSpecifier)===to a truthy constant (non-false, non-0, non-null, non-''), this implies the function returned non-false, enabling type-specifying extensions to narrow argument typesFuncCall,MethodCall, andStaticCallexpressions to avoid interfering with other narrowing handlers (e.g.,$object::class === 'Foo')strpos($s, ':') === 5→$sstays asstringstrpos($s, ':') === 5→$snarrowed tonon-falsy-string(via StrContainingTypeSpecifyingExtension)mb_strpos,strrpos,stripos,strripos, and theirmb_variantsextracted from #5508